Conversation
|
There are some PEP8 errors causing the tests to fail. Also you need to add a test for the example itself, this is pretty straightforward, just follow the lead of the other examples. A side benefit of adding a test is that we'll be able to see the resulting plot in the PR which makes it easier to review. |
There was a problem hiding this comment.
Typo: PLateCarree -> PlateCarree
There was a problem hiding this comment.
Typo: coordinate -> coordinate
|
I've only really just started on this, but given tweaks to data source noted in the diff I have got it to run + I see the resulting plot is really rather big. I'm not sure this plays nicely to the gallery Maybe you should consider separate figures for this reason -- you really need to play with building the docs + checking the results in a browser, and even experiment a bit with different window sizes and zooms. Tiresome, but unavoidable IMHO. |
|
these are now four separate figures |
|
Looks like you've only got one output file... did you mean to put |
meant to | should have done: done now anyhow cheers |
There was a problem hiding this comment.
Please avoid variable names in all caps, it makes them look like constants. PC is a little cryptic too.
There was a problem hiding this comment.
@marqh to ensure that the order of the tests run in the same order ...
for name in sorted(projections):
|
ok |
There was a problem hiding this comment.
@marqh You could slightly refactor this to be ...
projections = dict(Mollweide=ccrs.Mollweide(),
PlateCarree=ccrs.PlateCarree(),
NorthPolarStereo=ccrs.NorthPolarStereo(),
Orthographic=ccrs.Orthographic(central_longitude=-90,
central_latitude=45))
|
@bjlittle |
|
Lovely example, thanks @marqh 👍 |
5 participants
new example for plotting ORCA data